feat: Integrate coolbpf cpu profiling feature in loongcollector by wokron · Pull Request #2391 · alibaba/loongcollector

wokron · 2025-09-18T14:18:17Z

No description provided.

CLAassistant · 2025-09-18T14:18:24Z

All committers have signed the CLA.

Copilot

Pull Request Overview

This PR integrates coolbpf CPU profiling capabilities into loongcollector by adding a new input_cpu_profiling plugin. The implementation enables continuous CPU profiling of specified processes through command-line pattern matching and container discovery.

Key changes:

New CPU profiling plugin with process discovery mechanism
Integration with coolbpf profiler library
Plugin registration and lifecycle management

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
core/plugin/input/InputCpuProfiling.{h,cpp}	New plugin implementation for CPU profiling input
core/ebpf/plugin/cpu_profiling/*	Core CPU profiling manager and process discovery logic
core/ebpf/driver/CpuProfiler.h	Wrapper for coolbpf profiler library integration
core/ebpf/Config.{h,cpp}	CPU profiling configuration option handling
core/ebpf/include/export.h	Type definitions for CPU profiling
core/unittest/input/InputCpuProfilingUnittest.cpp	Unit tests for the input plugin
core/unittest/ebpf/*Unittest.cpp	Unit tests for CPU profiling components
Various CMakeLists.txt	Build system updates for new components

Comments suppressed due to low confidence (1)

core/unittest/input/InputCpuProfilingUnittest.cpp:1

Corrected spelling of 'CommandLines' to 'CommandLines' in comment context.

Copilot · 2025-11-06T02:19:24Z

+    mEBPFAdapter->UpdatePlugin(PluginType::CPU_PROFILING,
+                               buildCpuProfilingConfig(std::move(totalPids), std::nullopt, nullptr, nullptr));


Passing null handler and context to buildCpuProfilingConfig during update will overwrite the valid handler set during initialization, breaking profiling event handling.

看了代码，这是false-positive，但建议加一下注释，说明只能更新pid，不能更新其他，或者单独弄一个buildUpdateCpuProfilingConfig

yyuuttaaoo · 2026-02-25T07:34:27Z

使用文档仿照其他插件补充一下

yyuuttaaoo · 2026-02-26T06:55:11Z

+        std::lock_guard<std::mutex> lock(mMutex);
+        if (mProfiler == nullptr) {
+            livetrace_enable_tracing();
+            mProfiler = livetrace_profiler_create();


有没有控制队列大小等资源相关的参数，如何约束其资源使用量呢

队列大小的控制是 coolbpf 侧提供的。其中根据 profile 周期确定了有界队列的大小。https://gitee.com/anolis/coolbpf/blob/master/src/profiler/src/probes/probes.rs#L274

看了下，coolbpf 侧没有根据 profile 周期设置有界队列。队列是 unbounded，理论上如果消费者（LoongCollector Poll）跟不上生产速度，channel 会无限增长。队列大小控制完全不在 coolbpf 这一侧。

链接给错行数了 :( ，应该是下面 284 行

let ms = profile_period() as usize; let sample_per_sec = 1000 / ms; let ten_sec_samples = sample_per_sec * 10 * num_possible_cpus().unwrap_or(1); log::info!("cache max stack samples: {}", ten_sec_samples); let (tx, rx) = crossbeam_channel::bounded(ten_sec_samples);

其中 crossbeam_channel::bounded(ten_sec_samples); 创建一个有界队列，长度为 ten_sec_samples。

发送端 tx 传给了 thread_poll_trace_event 和 thread_poll_report_event 这两个 callback，分别在两个线程中 poll perf buffer。

接收端 rx 传给了 Probe。最后 livetrace_profiler_read 就是从接收端读取的数据。

wokron · 2026-03-06T00:29:54Z

使用文档仿照其他插件补充一下

文档已经补充了

Takuka0311 · 2026-04-27T08:23:59Z

百炼自动化审查：建议保持开启。

本 PR 为 LoongCollector 新增基于 coolbpf 的 CPU 性能剖析插件（input_cpu_profiling），包含核心 C++ 实现、eBPF 驱动适配、进程发现管理器、单元测试与中文文档。当前处于活跃审查阶段，维护者于 2026-05-12 提出多项代码质量与鲁棒性改进意见，作者已积极回应并修复部分问题，最新提交于 2026-05-18 推送。PR 当前可合并，需保持开启以待审查完成与合并。.

最佳落地路径：

建议作者继续跟进维护者 2026-05-12 的剩余审查意见（如 parseStackCnt 解析鲁棒性增强、Poll 空 PID 尾部数据 drain 逻辑、/proc 扫描频率优化及补充缺失单元测试），待 CI 通过且审查批准后由维护者合并。.

已核对内容：

active_review: 维护者 yyuuttaaoo 于 2026-05-12 提出 parseStackCnt 鲁棒性、Poll 空 PID 丢数据、/proc 扫描开销及 UT 缺失等审查意见；作者 wokron 于 05-13/05-14 积极回应，改用 Json::Value 处理转义，移除 GetContainerHostPath，补充 ContainerManager UT，并向上游 coolbpf 提交 API 改进 PR。. (core/ebpf/plugin/cpu_profiling/CpuProfilingManager.cpp:1, 9b0716c2831a)
mergeable_state: PR 当前 mergeable 状态为 true，已解决先前合并冲突，可进入最终审查与合并流程。. (eef380de68cb)
feature_addition: 新增 input_cpu_profiling 插件核心实现、eBPF 驱动适配（CpuProfiler）、进程发现管理器及完整单元测试与中文文档，属于有效且结构完整的新功能贡献。. (core/plugin/input/InputCpuProfiling.cpp:1, 9b0716c2831a)

百炼审查备注：模型 qwen3.6-max-preview；对照提交 b42ea269f84a。

yyuuttaaoo · 2026-05-12T15:57:03Z

+    StringView symbolView(symbol);
+    StringViewSplitter splitter(symbolView, "\n");
+    for (const auto& line : splitter) {
+        auto pos1 = line.find(';');


问题: parseStackCnt 用第一个 ; 分割 <comm>:<pid> 与栈，若 comm 含 ; 则全行解析错误

影响: /proc/*/comm 可含特殊字符（虽少见），解析错位会导致栈数据错乱或静默丢弃。

建议: 增强解析鲁棒性——从右侧匹配 :<pid>;，或在注释/文档中明确 coolbpf 的格式契约并加校验。

yyuuttaaoo marked this pull request as ready for review November 6, 2025 02:17

Copilot AI review requested due to automatic review settings November 6, 2025 02:17

Copilot AI reviewed Nov 6, 2025

View reviewed changes

wokron force-pushed the support-coolbpf-cpu-profiling branch from ecf5b83 to a3a8e56 Compare November 7, 2025 01:48

wokron force-pushed the support-coolbpf-cpu-profiling branch from c00d080 to 0f58800 Compare November 27, 2025 09:24

wokron force-pushed the support-coolbpf-cpu-profiling branch 5 times, most recently from 2a5948d to 6c51221 Compare December 22, 2025 02:21

yyuuttaaoo self-requested a review February 24, 2026 06:53

yyuuttaaoo requested changes Feb 25, 2026

View reviewed changes

yyuuttaaoo reviewed Feb 25, 2026

View reviewed changes

Comment thread core/ebpf/plugin/cpu_profiling/CpuProfilingManager.cpp Outdated

yyuuttaaoo reviewed Feb 26, 2026

View reviewed changes

Comment thread core/ebpf/driver/CpuProfiler.h Outdated

yyuuttaaoo reviewed Feb 26, 2026

View reviewed changes

wokron force-pushed the support-coolbpf-cpu-profiling branch 2 times, most recently from 37e01d9 to 8191f24 Compare March 4, 2026 03:00

yyuuttaaoo requested changes May 12, 2026

View reviewed changes

yyuuttaaoo reviewed May 12, 2026

View reviewed changes

Comment thread core/ebpf/plugin/cpu_profiling/CpuProfilingManager.cpp Outdated

wokron force-pushed the support-coolbpf-cpu-profiling branch from 54222e9 to 9f1231f Compare May 14, 2026 09:43

wokron added 6 commits May 15, 2026 12:20

link coolbpf libprofiler library

2412286

add CpuProfiler

50c039b

eBPFDriver support cpu profiling

de4be1a

add ProcessScanner

cfe000f

PluginOptions alias

6d8e04a

add CpuProfilingManager

e80fb1f

wokron added 20 commits May 18, 2026 11:51

update todo comment

75722a0

update ProcessDiscoveryManager sleep interval

0a01872

valNs use uint64

ea2d4f5

remove mContainerHandlersMutex

2a26202

clean up apply diff logic

4043dd1

refactor profiling collect interval

33860f3

parseStackCnt and addContentToEvent become static method

02127dc

unittest use shorter discovery interval

5b48e4e

check stack empty

f0a8314

reserve size in addContentToEvent

3bae9f7

extract FindAllMatch method

a980ac9

add process match cache

ff41a9e

add test for addContentToEvent

803f07b

update parseStackCnt

9167ac5

parseStackCnt unittest

fb5cfd4

add missing format

f9ad60d

add docs

2d464b6

reserve space for jsonLabels

36e46c2

also poll when pid is empty

d3ef097

better parseStackCnt

3cf84b5

wokron force-pushed the support-coolbpf-cpu-profiling branch from 9f1231f to 9b0716c Compare May 18, 2026 06:09

wokron added 8 commits May 19, 2026 10:41

use Json::Value

637ca23

remove GetContainerHostPath

c5088a0

add ContainerManager ut

d0f7bfc

optim process discovery cache

a2b43ef

remove uesless ListAllProcesses

295fec7

fix build

7d0bad7

format code

705f824

add comment

dd8648e

wokron force-pushed the support-coolbpf-cpu-profiling branch from eef380d to dd8648e Compare May 19, 2026 02:41

		mEBPFAdapter->UpdatePlugin(PluginType::CPU_PROFILING,
		buildCpuProfilingConfig(std::move(totalPids), std::nullopt, nullptr, nullptr));

Conversation

wokron commented Sep 18, 2025

Uh oh!

CLAassistant commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

yyuuttaaoo May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yyuuttaaoo commented Feb 25, 2026

Uh oh!

Uh oh!

Uh oh!

yyuuttaaoo Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

wokron Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

yyuuttaaoo May 12, 2026

Choose a reason for hiding this comment

Uh oh!

wokron May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wokron commented Mar 6, 2026

Uh oh!

Takuka0311 commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yyuuttaaoo May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Sep 18, 2025 •

edited

Loading

wokron May 13, 2026 •

edited

Loading

Takuka0311 commented Apr 27, 2026 •

edited

Loading